Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Render Delegate's material binding pupose #3352

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

robpieke
Copy link
Contributor

@robpieke robpieke commented Oct 8, 2024

Description of Change(s)

Changing the SceneIndexAdapterSceneDelegate to query the render delegate's material binding purpose so that the correct material binding is retrieved. This (largely) addresses a regression mentioned below, though there could still be issues with hdPrman and/or Storm which still exercise the old code path.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

…red) material binding.

Note there still remain calls to the generic GetMaterialBinding() in:
* collectionPredicateLibrary - hd
* materialPrimvarTransferSceneIndex - hdSi
* dependencySceneIndexPlugin - hdSt
* retesselationSceneIndexPlugin - hdPrman
@robpieke robpieke changed the base branch from release to dev October 8, 2024 14:37
@jesschimein
Copy link

Filed as internal issue #USD-10264

@jesschimein
Copy link

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"full" material binding not working with USDIMAGINGGL_ENGINE_ENABLE_SCENE_INDEX=1
3 participants